Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger activate event when app is activated via app switcher #23775

Merged
merged 1 commit into from
May 27, 2020
Merged

fix: trigger activate event when app is activated via app switcher #23775

merged 1 commit into from
May 27, 2020

Conversation

isnotgood
Copy link
Contributor

Manual backport of #23727

See that PR for details.

Notes: none

When application is activated thru macOS app switcher (cmd+tab) the
App's activate event is note emitted. The reason is that
`applicationShouldHandleReopen:hasVisibleWindows:` is sent only when app
is activated via Dock. Using `applicationDidBecomeActive:` is handling
all cases properly.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 26, 2020
@trop trop bot added 7-3-x backport This is a backport PR labels May 26, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 26, 2020
@zcbenz zcbenz merged commit 3a568ab into electron:7-3-x May 27, 2020
@release-clerk
Copy link

release-clerk bot commented May 27, 2020

No Release Notes

zcbenz added a commit that referenced this pull request May 28, 2020
jkleinsc pushed a commit that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-3-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants